make collation tests work with only warnings when omitting rule strings

Description

genrb --omitCollationRules builds collation data and then drops the rule strings. Tests should pass with that with only warnings when the appropriate test flag is set.

Activity

Show:
TracBot
June 30, 2018, 11:57 PM
Trac Comment 1 by —2014-01-15T19:20:45.507Z

Steven suggests to have a central test for whether any rule strings are available, and not even attempting related tests when no rule strings are there.

Best done after the collv2 code is merged in, which makes fewer Collator APIs depend on rule strings.

TracBot
June 30, 2018, 11:57 PM
Trac Comment 4 by —2014-03-30T07:33:06.903Z

I added a patch that makes the tests pass if -w is specified, which turns certain errors into warnings. Tested with `INTLTEST_OPTS=-w CINTLTST_OPTS=-w make -j5 check`.

I built `$(COLBLDDIR)/%.res` with genrb option `--omitCollationRules`. I also removed the big5han and gb2312han tailorings. (They are not really useful sort orders but take up 192kB even without the rule strings.)

It would be nice to add testing with `--omitCollationRules` to our release tasks.

TracBot
June 30, 2018, 11:57 PM
Trac Comment 5 by —2014-04-01T20:00:42.736Z

Fixed for ICU4C. I did not attempt to make these changes for ICU4J.

Fixed

Assignee

Markus Scherer

Reporter

Markus Scherer

Components

Labels

None

Reviewer

None

Priority

medium

Time Needed

Hours

Fix versions