#include <xlocale.h> must be #include <locale.h> for CLANG build on Arch Linux

Description

digilist.cpp will not compile in Arch Linux due to xlocale.h being Xlocale.h on Arch Linux Machines:

https://www.archlinux.org/packages/extra/x86_64/libx11/files/

The following change will make the build work correctly for Arch Linux builds:

Activity

Show:
TracBot
June 30, 2018, 11:46 PM
Trac Comment 9 by erack@d55f6f1274465e6b—2017-09-13T10:49:12.212Z

Or rather, you have to keep xlocale.h for the broken macOS that doesn't follow POSIX 2008, and for other systems might use <ctype.h> as defined or get away with locale.h for systems that don't follw that either.

TracBot
June 30, 2018, 11:46 PM
Trac Comment 10 by Eike Rathke <erack@e301bebf79920c93—2017-09-13T12:01:22.405Z

This is a conservative approach, but should be extended to cover all POSIX.2008 platforms. Note that U_PLATFORM_IMPLEMENTS_POSIX is not suitable.

TracBot
June 30, 2018, 11:46 PM
Trac Comment 11 by Eike Rathke <erack@e301bebf79920c93—2017-09-13T20:29:15.916Z

Btw, it could be helpful to change the title of this ticket and if possible also the first description, otherwise people might read about Xlocale.h and casing and stop reading..

TracBot
June 30, 2018, 11:46 PM
Trac Comment 12 by —2017-10-06T14:44:58.587Z

Changed the description. I was not sure about this, but we also got another ticket - #13385, and reproduced the issue with glibc 2.26.

I think we need to detect if the new POSIX.1-2008 locale_t stuff are defined in xlocale.h or locale.h by autoconf.

Anyway, updated the description.

TracBot
June 30, 2018, 11:46 PM
Trac Comment 13 by —2017-10-09T21:22:25.824Z

Closing this one - see #13385.

Assignee

Yoshito Umaoka

Reporter

TracBot

Components

Labels

None

Reviewer

None

Priority

assess

Time Needed

Hours

Fix versions

Configure