Enable -Wextra-semi (or -Wall) in ICU4C

Description

V8 builds with this flag, and there are some ICU header files that produce this warning. Would be nice to clean them up and enable this warning in the default ICU4C build.

We should also consider using -Wall and using a blacklist rather than a whitelist of warning codes.

Activity

Show:
Shane Carr
August 13, 2019, 6:58 PM

Closing as duplicate of

Jungshik Shin
March 23, 2019, 4:22 AM

is a stronger form of this. Without treating warning as error, -Wall doesn't help much.

Jeff Genovy
March 21, 2019, 12:30 AM

Also somewhat related: (Adding a build bot that treats warnings as errors.)

Shane Carr
March 13, 2019, 6:21 PM

-Wall is a moving target, but without it, we have to manually add warning flags, which we clearly don't do on a regular bases, and we get dozens of tickets, each for a different random warning that we aren't catching. Using -Wall with a blacklist of warnings we don't want to fix seems like it is easier to maintain.

Steven R. Loomis
March 13, 2019, 6:05 PM

-Wall is a moving target

Fixed
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Shane Carr

Reporter

Shane Carr

Components

Reviewer

Steven R. Loomis

Priority

major

Time Needed

Hours

Fix versions