We're updating the issue view to help you get more done. 

ICU4C: Shared library ProjectConfiguration Props file ignores command line preprocessor defines.

Description

There is a shared .props file that is used by the various ICU library components to set common/shared settings like "no exceptions", and various warnings configurations.
icu4c\source\allinone\Build.Windows.Library.ProjectConfiguration.props
Link:
https://github.com/unicode-org/icu/blob/master/icu4c/source/allinone/Build.Windows.Library.ProjectConfiguration.props

However, this file currently ignores any preprocessor defines that are set on the command line using MSBUILD.

This unfortunately breaks some scenarios where various flags need to be set using MSBUILD.

The fix is a one line change to add $(DefineConstants); to the file.

See the link below for the change:
https://github.com/unicode-org/icu/compare/maint/maint-64...jefgen:jefgen/msbuild-command-line-defines

Status

Assignee

Jeff Genovy

Reporter

Jeff Genovy

Labels

None

Reviewer

None

Time Needed

None

Start date

None

Components

Fix versions

Priority

critical