Treat MSVC warning C4910 and C4003 as errors in the CI builds

Description

Looking at the proposed changes for ICU-9749, an additional warning is now being generated in the MSCV builds.

The warning is:

However, I believe that this warning should be an error. (This will cause ICU to fail to build for us internally).

With ICU-20200, we now treat a limited subset of warnings as errors for MSVC, two of which are for DLL exports or explicit template instantiations.
(Ex: C4661 "No suitable definition provided for explicit template instantiation request" as an error.)

I believe we should add this warning (C4910) to the list of errors as well.

Activity

Show:
Jeff Genovy
April 15, 2019, 8:19 PM
Jeff Genovy
April 11, 2019, 8:29 PM

Need to wait for to be merged to master.
(Shane has a PR here: https://github.com/unicode-org/icu/pull/617)

Jeff Genovy
March 27, 2019, 5:45 PM

Per ICU-TC call on 2019-03-27, will take this to make both 4910 and 4003 errors.

Jeff Genovy
March 23, 2019, 12:39 AM
Edited

We should likely also treat C4003 as an error too (See ICU-20516).

Fixed
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Jeff Genovy

Reporter

Jeff Genovy

Components

Reviewer

Daniel Ju

Priority

minor

Fix versions