UPRV_UNREACHABLE called in code that is easily reachable, crashes production code
Description
UPRV_UNREACHABLE, which now unconditionally calls abort(), is called in u_UCharsToChars() if that function is passed a non-invariant character:
1
2
3
if(!UCHAR_IS_INVARIANT(u)) {
UPRV_UNREACHABLE; /* Variant characters were used. These are not portable in ICU. */
}This used to call U_ASSERT which is a no-op in production code:
1
2
3
4
if(!UCHAR_IS_INVARIANT(u)) {
U_ASSERT(FALSE); /* Variant characters were used. These are not portable in ICU. */
u=0;
}This UPRV_UNREACHABLE can easily be reached not only by direct calls to u_UCharsToChars (in which case there is at least API documentation that says that it is not intended for non-invariant chars) but indirectly, e.g. via a call to ucal_getTimeZoneIDForWindowsID() that is passed a (presumably malformed) Windows zoneID containing non-invariant chars.
This is rather bad.
Status
Assignee
Peter Edberg
Reporter
Peter Edberg
Labels
Reviewer
None
Time Needed
Hours
Start date
None
Components
Fix versions
Priority
critical