Multi-line comment in umachine.h

Description

I started to see this on g++ ( 7.4.0-1ubuntu2.3 ):

1 2 3 4 5 6 7 In file included from /src/icu/icu4c/source/common/unicode/utypes.h:38:0, from /src/icu/icu4c/source/common/unicode/uobject.h:22, from /src/icu/icu4c/source/common/sharedobject.h:15, from /src/icu/icu4c/source/common/sharedobject.cpp:10: /src/icu/icu4c/source/common/unicode/umachine.h:158:1: warning: multi-line comment [-Wcomment] // CPPFLAGS='-DUPRV_BLOCK_MACRO_BEGIN="" -DUPRV_BLOCK_MACRO_END=""' \ ^

Turns out this is the cause, sure enough there is a multiline comment from ’s fix:

1 2 3 4 5 6 7 // This will however break existing code that depends on being able to invoke // these macros without a trailing ; so to be able to remain compatible with // such code the wrapper is itself defined as macros so that it's possible to // build ICU 65 and later with the old macro behaviour, like this: // // CPPFLAGS='-DUPRV_BLOCK_MACRO_BEGIN="" -DUPRV_BLOCK_MACRO_END=""' \ // runConfigureICU ...

Status

Assignee

Steven R. Loomis

Reporter

Steven R. Loomis

Labels

None

Reviewer

None

Time Needed

None

Start date

None

Components

Fix versions

Priority

trivial