build issue on Solaris/sparc

Description

Build on Solaris 11/sparc fails with the below error:
...
make[2]: Leaving directory '/builds/pheimlic/icu/components/icu/build/sparcv7/tools'
/usr/gnu/bin/make[1]: Making `all' in `data'
make[2]: Entering directory '/builds/pheimlic/icu/components/icu/build/sparcv7/data'
/usr/gnu/bin/make -f pkgdataMakefile
make[2]: *** No rule to make target 'out', needed by 'out/icudt65b.dat'. Stop.

I had to workaround it with this patch:
{{--- icu4c-65_1/icu/source/data/Makefile.in.old 2019-10-04 10:50:00.965892341 +0200
+++ icu4c-65_1/icu/source/data/Makefile.in 2019-10-04 10:50:09.265554606 +0200
@@ -148,7 +148,8 @@

  1. and convert it to the current type.
    ifneq ($(ICUDATA_ARCHIVE),)
    ICUDATA_SOURCE_ARCHIVE = $(OUTDIR)/$(ICUDATA_PLATFORM_NAME).dat
    -$(ICUDATA_SOURCE_ARCHIVE): $(ICUDATA_ARCHIVE) $(OUTDIR)
    +$(ICUDATA_SOURCE_ARCHIVE): $(ICUDATA_ARCHIVE)
    + $(MKINSTALLDIRS) $(OUTDIR)
    $(INVOKE) $(TOOLBINDIR)/icupkg -t$(ICUDATA_CHAR) $(ICUDATA_ARCHIVE) $(ICUDATA_SOURCE_ARCHIVE)
    endif
    else}}

Activity

Show:
Mojca Miklavec
April 2, 2020, 6:27 PM

Sure, the fix has been committed a month ago.

Markus Scherer
April 2, 2020, 6:09 PM

ready to close as fixed?

Arfrever Frehtes Taifersar Arahesis
February 29, 2020, 7:10 PM

Fixed in commit 4a3a457b38cd828b7b3fa4fdbc6e2504a57275e9 ( ).

Mojca Miklavec
January 14, 2020, 2:24 PM
Edited

The patch works for me as well. I filed a pull request to speed up the process.

Should I put Steven as the commit author?

Steven R. Loomis
December 4, 2019, 6:24 PM

this looks like a good change, can you make a PR?

Fixed
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Steven R. Loomis

Reporter

Pavel Heimlich

Components

Priority

major

Time Needed

Minutes

Fix versions