Change ICU data file header (for generated files) to remove obsolete license URL fragment

Description

Markus suggested in that the current header for generated files was incorrect and should be changed to remove the license information (2nd line).


© 2016 and later: Unicode, Inc. and others.
License & terms of use: http://www.unicode.org/copyright.html#License


becomes:


© 2016 and later: Unicode, Inc. and others.


I have no opinion on this and it's a one line change, but means that the next time anyone regenerates the files, they need to specify the "force overwrite" flag and check for files which should be deleted manually (since the header is used to check for whether a file is auto-generated or not). To make this sort of thing more robust in future, I suggest an alternative which is to add a new stable "Auto-generated by ..." line which can be used as a better signal to the cleanup code. Something like:


© 2016 and later: Unicode, Inc. and others.
Auto-generated using tools/cldr/cldr-to-icu/build-icu-data.xml.


Obviously this extra line would have to be stable, so would probably not want version numbers etc. in (that just complicates things).

Activity

Show:
Markus Scherer
September 9, 2020, 12:25 AM

Closing for ICU 68. The data files have been regenerated with a new was-generated-label, the #License suffix has been removed from the header template, and I created follow-up ticket for the TODO cleanup.

Markus Scherer
August 19, 2020, 4:33 PM

No. What I said is “we don’t use the #License part.“

We do need the line with the link to the license page, but that page has no #License anchor so that part is useless, and none of the source code has that.

For example:

The extra “generated” line is ok if it helps. We often have that kind of comment.

David Beaumont
August 19, 2020, 11:45 AM

The file to be changed is:

tools/cldr/cldr-to-icu/src/main/resources/ldml2icu_header.txt

Fixed
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

David Beaumont

Reporter

David Beaumont

Components

Labels

Priority

medium

Fix versions