Use AS_HELP_STRING Macro to Ensure Consistent '--with' Help Output

Description

From: Grant Erickson <gerickson@nuovations.com>
Subject: [PATCH] Use AS_HELP_STRING Macro to Ensure Consistent '--with' Help Output
Organization: Nuovation System Designs, LLC

Use AS_HELP_STRING macro to ensure consistent help output for '--with'
options regardless of the length of the option or the assoiated help
description.

Signed-off-by: Grant Erickson <gerickson@nuovations.com>

Also submitted via ICU TRAC.

source/configure.in | 9 ++++++---
#files changed, 6 insertions, 3 deletions

diff --git a/source/configure.in b/source/configure.in
index 524324a..c6e40ee 100644
— a/source/configure.in
+++ b/source/configure.in
@@ -464,7 +464,8 @@ fi
AC_SUBST(U_HAVE_INTTYPES_H)

AC_ARG_WITH(iostream,
- [ --with-iostream=version specify the version of iostream to use (none, old, std, auto) @<:@default=auto@:>@],
+ AS_HELP_STRING([--with-iostream=VERSION],
+ [the version of iostream to use (none, old, std, auto) @<:@default=auto@:>@|specify]),
["${withval}" in
none) streams=none ;;
old) streams=198506 ;;
@@ -924,7 +925,8 @@ AC_ARG_ENABLE(layout,
ICU_CONDITIONAL(LAYOUT, test "$layout" = true)

AC_ARG_WITH(data-packaging,
- [ --with-data-packaging=type specify how to package ICU data (files, archive, library, auto) @<:@default=auto@:>@|case],
+ AS_HELP_STRING([--with-data-packaging=TYPE],
+ [how to package ICU data (files, archive, library, auto) @<:@default=auto@:>@|specify]),
["${withval}" in
files|archive|library) datapackaging=$withval ;;
auto) datapackaging=$withval ;;
@@ -970,7 +972,8 @@ AC_SUBST(DATA_PACKAGING_MODE)
dnl Sets a library suffix
AC_MSG_CHECKING([for a library suffix to use|case])
AC_ARG_WITH(library-suffix,
- [ --with-library-suffix=suffix tag a suffix to the library names @<:@default=@:>@],
+ AS_HELP_STRING([--with-library-suffix=SUFFIX],
+ [a suffix to the library names @<:@default=@:>@|tag]),
[ICULIBSUFFIX="${withval}"],
[ICULIBSUFFIX=])
msg=$ICULIBSUFFIX

1.6.1.2

Activity

Show:
Markus Scherer
July 22, 2020, 10:52 PM

tracReporter=gerickson

Assignee

Steven R. Loomis

Reporter

TracBot

Components

Reviewer

None

Priority

assess

Time Needed

None

Fix versions

None
Configure