Fixed
Details
Details
Components
Labels
Priority
Fix versions
Phase
pre-sub
Assignee
Thomas Bishop
Thomas BishopReviewer
Steven R. Loomis
Steven R. LoomisReporter
Thomas Bishop
Thomas BishopCreated January 11, 2019 at 5:18 AM
Updated December 4, 2020 at 6:41 PM
Resolved October 3, 2019 at 8:32 PM
We have code in .jsp files that would be easier to work with if it were in ordinary .java files. For example, RefreshRow.jsp is essentially all Java code. Because it's in a .jsp file, however, some standard Eclipse features don't work, such as warnings for unused variables, and the ability to jump to function declarations. The formatting of RefreshRow.jsp (indentation, etc.) is a mess. Code conventions from Oracle recommend "avoid writing Java code ... in your JSP pages". I've tested moving all of the code in RefreshRow.jsp into a new function in SurveyAjax.java, and simply calling that function from RefreshRow.jsp. With that change, the code still appears to run correctly, and numerous warnings are revealed that should be fixed.