Run exemplars data through data check
General
Trac Info
General
Trac Info
Description
Attachments
1
relates to
Activity
UnicodeBot May 9, 2019 at 10:36 PM
Trac Comment 20 by —2017-03-09T12:55:45.486Z
Reviewer: data part looks good. Passing on to someone else for the code review, since I wrote that part.
UnicodeBot May 9, 2019 at 10:36 PM
Trac Comment 19 by —2017-03-08T18:34:49.128Z
See for the remaining tasks.
UnicodeBot May 9, 2019 at 10:36 PM
Trac Comment 17 by —2017-03-08T16:26:44.598Z
Sascha, please mark this for review, and separate the remaining work in a new ticket for next time.
UnicodeBot May 9, 2019 at 10:36 PM
Trac Comment 16 by —2017-02-06T12:43:50.809Z
8 failures left:
UnicodeBot May 9, 2019 at 10:36 PM
Trac Comment 15 by —2017-02-03T06:02:13.563Z
Can you try this now to see if it all works?
Unresolved
Details
Details
Priority
Fix versions
Assignee
Sascha Brawer
Sascha BrawerReviewer
John Emmons
John Emmons(Deactivated)Reporter
Sascha Brawer
Sascha BrawerCreated January 11, 2019 at 4:57 AM
Updated May 9, 2019 at 10:36 PM
Deleted Component: other
The CLDR tests should run the contents of the exemplars directory through the data checks. For example, this would have prevented .
I’ve tried to fix it, but stumbled at the following. When changing tools/cldr-unittest/build.xml to pass "-S common,exemplars,seed" as `datacheck.arg` when running the command "ant cldr.datacheck.logged" in tools/cldr-unittest, the test suite crashes in tools/java/org/unicode/cldr/util/SimpleFactory.java on line 490:
The reason is that SimpleFactory.getSourceDirectoryForLocale() returns null. Its implementation calls `CLDRFile.isSupplementalName(localeName)` to determine whether the locale is in supplemental. The implementation of `CLDRFile.isSupplementalName()` is this:
However, `SUPPLEMENTAL_NAMES`, which is defined in tools/java/org/unicode/cldr/util/CLDRFile.java on line 117, is not actually a locale name, but rather looks like a list of XML attribute:
Maybe that’s a red herring. In any case, it would be good to run the contents of `exemplars` through the data checks.